[FreeBSD] Enable CFRunLoop support #5188
Conversation
|
@swift-ci test |
| @@ -120,7 +120,7 @@ open class RunLoop: NSObject { | |||
| // Make sure we honor the override -- var currentCFRunLoop will do so on platforms where overrides are available. | |||
|
|
|||
| // TODO: This has been removed as public API in port to the package, because CoreFoundation cannot be available as both toolchain "CoreFoundation" and package "_CoreFoundation" | |||
| #if os(Linux) || os(macOS) || os(iOS) || os(tvOS) || os(watchOS) || os(OpenBSD) | |||
There was a problem hiding this comment.
Should this just be #if !os(Windows)? Otherwise it seems like we'll just need to keep tweaking this over and over again. We probably want to take this code path on visionOS, NetBSD, Solaris, Android, and so on, right?
There was a problem hiding this comment.
I think this is not necessarily true, since whether we should enable this code path depends on if such platform implemented the bits to support CFRunLoop, which is not necessarily true and by default we should assume it does not have support.
|
@swift-ci please test |
|
@swift-ci please test |
|
The crash on Linux should be fixed by swiftlang/swift#82176. |
|
@swift-ci please test Linux |
|
@swift-ci please test Windows |
|
swiftlang/swift-driver#1931 |
|
@swift-ci please test Windows |
This patch enables CFRunLoop for FreeBSD.
Related libdispatch PR: swiftlang/swift-corelibs-libdispatch#861