Skip to content

Make sure that the once used for Process is static #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

Make sure that the once used for Process is static #5038

merged 1 commit into from
Jul 30, 2024

Conversation

parkera
Copy link
Contributor

@parkera parkera commented Jul 30, 2024

Do not re-add sources to the run loop for each call to setup. Regression from #5000.

@parkera parkera requested review from compnerd and jmschonfeld July 30, 2024 18:49
@parkera
Copy link
Contributor Author

parkera commented Jul 30, 2024

@swift-ci test

jmschonfeld
jmschonfeld approved these changes Jul 30, 2024
View reviewed changes
@parkera
Copy link
Contributor Author

parkera commented Jul 30, 2024

@swift-ci test windows

@parkera
Copy link
Contributor Author

parkera commented Jul 30, 2024

@shahmishal it looks like something might be wrong with the windows hosts?

Running ``update_single_repository`` with up to 72 processes.
======UPDATE FAILURES======
C:\Users\swift-ci\jenkins\workspace\swift-corelibs-foundation-PR-windows\swift failed (ret=1): ['git', 'checkout', 'main']
b"error: pathspec 'main' did not match any file(s) known to git\n"
update-checkout failed, fix errors and try again
Build step 'Execute Windows batch command' marked build as failure

@parkera
Copy link
Contributor Author

parkera commented Jul 30, 2024

I'm going to go ahead and merge this despite the Windows CI issue.

@parkera parkera merged commit 1ed5181 into swiftlang:main Jul 30, 2024
1 of 3 checks passed
@parkera parkera deleted the parkera/fix_process_race branch July 30, 2024 22:06
parkera added a commit to parkera/swift-corelibs-foundation that referenced this pull request Jul 30, 2024
@parkera
Make sure that the once used for Process is static, so not recreated …
44a22ad 
…for each setup (swiftlang#5038)

(cherry picked from commit 1ed5181)
@parkera parkera mentioned this pull request Jul 30, 2024
Merged
parkera added a commit that referenced this pull request Jul 31, 2024
@parkera
Make sure that the once used for Process is static, so not recreated …
28316c7 
…for each setup (#5038) (#5039)

(cherry picked from commit 1ed5181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@jmschonfeld jmschonfeld jmschonfeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parkera @compnerd @jmschonfeld