[wasm] Port thread-related APIs for no thread platform #4870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
kateinoigakukun
force-pushed
the
pr-c5d9ac3f9d224d05c5fd7a1445ef1f46d072610e
branch
from
e325d29 to
ba87b62
Compare
|
@swift-ci test |
This change ports the thread-related APIs for the no thread platform by adding no-op implementations. Note that WASI is going to support threads in the near future, so this does not guard by `TARGET_OS_WASI` but by `!SWIFT_CORELIBS_FOUNDATION_HAS_THREADS` to make it easier for future WASI + threads support.
kateinoigakukun
force-pushed
the
pr-c5d9ac3f9d224d05c5fd7a1445ef1f46d072610e
branch
from
ba87b62 to
3744d4d
Compare
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
approved these changes
Feb 24, 2024
kateinoigakukun
deleted the
pr-c5d9ac3f9d224d05c5fd7a1445ef1f46d072610e
branch
|
This seems to have caused a regression on macOS builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ports the thread-related APIs for the no thread platform by adding no-op implementations. Note that WASI is going to support threads in the near future, so this does not guard by
TARGET_OS_WASIbut by!SWIFT_CORELIBS_FOUNDATION_HAS_THREADSto make it easier for future WASI + threads support.