Skip to content

Swift VALIDATE_MODULE_DEPENDENCIES followup: track in signature, switch unsupported toolchain from error to warning #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Swift VALIDATE_MODULE_DEPENDENCIES followup: track in signature, switch unsupported toolchain from error to warning #649

wants to merge 2 commits into from

Conversation

mirza-garibovic
Copy link
Contributor

  • Dependencies: include moduleDependenciesContext in the Swift compilation requirements signature
  • Dependencies: emit warning instead of error if the Swift toolchain can't support VALIDATE_MODULE_DEPENDENCIES to match clang

@mirza-garibovic
Copy link
Contributor Author

@swift-ci test

bob-wilson
bob-wilson approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@bob-wilson bob-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirza-garibovic
Copy link
Contributor Author

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenv owenv owenv approved these changes

@bob-wilson bob-wilson bob-wilson approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh aciidgh is a code owner

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@mhrawdon mhrawdon Awaiting requested review from mhrawdon mhrawdon is a code owner

@neonichu neonichu Awaiting requested review from neonichu neonichu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirza-garibovic @owenv @bob-wilson