Dependencies: validate Swift imports against MODULE_DEPENDENCIES and provide fix-its (rdar://154967562) #641
+794
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly declarative right now, but does inform implicit dependencies. (cherry picked from commit 475fde5)
…gs (swiftlang#513) This can be used to emit fix-its for XCConfigs files during the build process. (cherry picked from commit eca9ed5)
In swiftlang#513, initial support for this was added, this PR moves the location to be per assignment which allows emitting fix its not just for the last seen assignments. This will also allow looking at any conditions of assignments when choosing the location for emitting fix its. (cherry picked from commit db41e13)
Originally only one line was tracked here (the end line effectively), but we also have to track the start line separately for correct multi-line ranges. (cherry picked from commit b78e04a)
…ss condition binding (cherry picked from commit 30ec11c)
…provide fix-its (rdar://154967562) (cherry picked from commit 572505d)
mirza-garibovic
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci test |
owenv
approved these changes
Jul 3, 2025
|
Need swift-driver changes from main into 6.2, following up. |
jakepetroules
approved these changes
Jul 3, 2025
|
Got swiftlang/swift#82779 and waiting on swiftlang/swift-driver#1950 |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks macro location tracking, MODULE_DEPENDENCIES, VALIDATE_MODULE_DEPENDENCIES, and Swift import validation.