Skip signature help tests if not supported in sourcekitd #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7medev
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
bnbarham
approved these changes
Sep 5, 2025
|
@swift-ci please test |
|
@bnbarham Do we need to run Windows tests too? 👀 |
|
They've started: https://ci-external.swift.org/job/sourcekit-lsp-PR-windows/3262/. Sometimes need to re-run after a force push because of a bug, but the fresh PR should work needing to request separately 😅 |
hamishknight
approved these changes
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signature help was introduced in #2250 but its tests were run unconditionally.
This PR skips signature help tests if sourcekitd doesn't support it (e.g. when running the tests against an older version of the toolchain).