Do not poll index in testTargetsAreIndexedInDependencyOrder
#2282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't poll the index using `workspace/synchronize` because that elevates the priority of the indexing requests in a non-deterministic order (due to the way `withTaskPriorityChangedHandler` is implemented using polling). If LibB's priority gets elevated before LibA's, then LibB will get prepared first, which is contrary to the background behavior we want to check here Fixes swiftlang#2281
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
bnbarham
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't poll the index using
workspace/synchronizebecause that elevates the priority of the indexing requests in a non-deterministic order (due to the waywithTaskPriorityChangedHandleris implemented using polling). If LibB's priority gets elevated before LibA's, then LibB will get prepared first, which is contrary to the background behavior we want to check hereFixes #2281