[6.0] Import new Bionic module and Android overlay #1555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
approved these changes
Jul 4, 2024
|
@swift-ci Please test |
bnbarham
approved these changes
Jul 5, 2024
|
Hold off on merging, will let you know next week. |
finagolfin
changed the title
|
Alright, pulled in #1559 also, one more CI run and this can go in. |
|
@swift-ci please test |
|
Passed CI, ready for merge. |
|
Seems like Windows didn't run :( |
|
@swift-ci please test Windows platform |
It did, I think the problem is that github doesn't always pick up the results of Windows CI runs. |
Yeah, unfortunately merging is blocked for me without the status being picked up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Now that this new overlay was merged into the 6.0 compiler too in swiftlang/swift#74758, this adds the overlay to the seven files that currently
import Glibc.Scope: Add imports on Android only
Issue: None
Original PR: #1550 and #1559
Risk: None
Testing: Passed all CI on trunk, plus on my daily Android CI, finagolfin/swift-android-sdk#151
Reviewer: @ahoppen
@bnbarham, easy review.