[NFC][lldb] Adapt LLDB to RemoteInspection's RemoteAddress changes #10981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4dc8b19)
Adapts LLDB to the new field in RemoteAddress. This is an NFC that maintains the current behavior. A follow up patch will be introduced later that takes advantage of the new behavior to fix a bug in reading metadata from files instead of the process. rdar://148361743 (cherry picked from commit 12f429a)
Now that RemoteAddress carries its address space, instead of using a high bit to turn on the filecache optimization, use that instead. This way we are guaranteed to not clash with any pointer authentication masks. rdar://148361743 (cherry picked from commit b283038e2aad625ff455a10f2590ed2501c987eb)
JDevlieghere
approved these changes
Jul 14, 2025
| @@ -51,7 +51,7 @@ class MemoryReaderLocalBufferHolder { | |||
|
|
|||
| class LLDBMemoryReader : public swift::remote::MemoryReader { | |||
| public: | |||
|
|
|||
| static constexpr uint8_t LLDBAddressSpace = 1; | |||
There was a problem hiding this comment.
Maybe add a comment here saying that anything but address space 0 is fair play and that each tool/client can define their own, so there's no risk trampling over someone else's address space.
There was a problem hiding this comment.
I'll add a comment on the stable branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that RemoteAddress carries its address space, instead of using a
high bit to turn on the filecache optimization, use that instead. This
way we are guaranteed to not clash with any pointer authentication
masks.