[Index] Add option to compress unit and record files #10977
+189
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test llvm |
bnbarham
approved these changes
Jul 11, 2025
| @@ -0,0 +1,8 @@ | |||
| // RUN: rm -rf %t.idx | |||
| // RUN: %clang_cc1 %s -index-store-path %t.idx -index-store-compress-records | |||
There was a problem hiding this comment.
I assume you switched to compressing both at some point?
Reading all unit and record files of a reasonably sized mixed Swift + C test project increased by ~25% (189ms vs. 152ms). I would argue that the 60-70% size savings (12MB vs. 40MB / 16.6MB on disk vs. 44.4MB on disk) are worth that performance regression in the millisecond range. |
ahoppen
force-pushed
the
compress-records
branch
from
17fcd27 to
4465df2
Compare
|
@swift-ci Please test llvm |
This option reduces the size of the index in a mixed clang + Swift project I have tested by about 70% while increasing the indexing overhead by about 10-15% overhead (from 1.07% to ~1.2%).
ahoppen
force-pushed
the
compress-records
branch
from
4465df2 to
626ae63
Compare
|
@swift-ci Please test llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option reduces the size of the index in a mixed clang + Swift project I have tested by about 70% while increasing the indexing overhead by about 10-15% overhead (from 1.07% to ~1.2%).