Skip to content

MIgrate to GH actions #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 20, 2024
Merged

MIgrate to GH actions #22

merged 8 commits into from
Nov 20, 2024

Conversation

adam-fowler
Copy link
Member

Migrate CI to use GitHub Actions.

Motivation:

To migrate to GitHub actions and centralised infrastructure.

Modifications:

Changes of note:

Adopt swiftlang soundness checks, swift version matrix
Remove scripts and docker files which are no longer needed

@adam-fowler adam-fowler added the semver/none No version bump required. label Nov 13, 2024
@adam-fowler
Copy link
Member Author

@rnro this is pretty much a copy of the swift-openapi-async-http-client setup with the license header check disabled as it adds Apple to the license headers.

@adam-fowler adam-fowler requested a review from Joannis November 13, 2024 10:21
@rnro
Copy link

rnro commented Nov 13, 2024

Awesome. Looks good except for the Package.swift formatting failure. I'll have a look at if it would be possible to add a license header check for non-Apple repositories.

@adam-fowler
Copy link
Member Author

Awesome. Looks good except for the Package.swift formatting failure.

Fixed

I'll have a look at if it would be possible to add a license header check for non-Apple repositories.

Yeah would be good

@rnro
Copy link

rnro commented Nov 13, 2024

Actually @adam-fowler you should be able to do something like this https://github.com/grpc/grpc-swift/blob/main/.license_header_template

Comment on lines +26 to +28
cxx-interop:
name: Cxx interop
uses: apple/swift-nio/.github/workflows/cxx_interop.yml@main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this used for?

@adam-fowler adam-fowler merged commit 4e86cce into main Nov 20, 2024
26 checks passed
@adam-fowler adam-fowler deleted the gh-actions branch November 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants