Weakly capture the HTTPConnectionPool in the idle connection timeout task
#853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t task Currently, the `HTTPConnectionPool` will be kept alive until the idle connection timeout has fired. I don’t see a reason to keep the `HTTPConnectionPool` around if the idle connection timeout future is the only thing that’s still referencing the `HTTPConnectionPool`.
Lukasa
reviewed
Aug 18, 2025
| @@ -394,7 +394,10 @@ final class HTTPConnectionPool: | |||
| "ahc-connection-id": "\(connectionID)" | |||
| ] | |||
| ) | |||
| let scheduled = eventLoop.scheduleTask(in: self.idleConnectionTimeout) { | |||
| let scheduled = eventLoop.scheduleTask(in: self.idleConnectionTimeout) { [weak self] in | |||
There was a problem hiding this comment.
We should avoid the use of a weak reference here: its performance impact will be very substantial.
Instead, so long as all of these tasks are cancelled in the shutdown routine (as they should be), there will be no leak, as the cancellation of the tasks will drop the function reference.
Lukasa
requested changes
Aug 18, 2025
|
OK, gotcha. The case where I hit this has changed slightly so that this is no longer relevant for me, so I won’t be putting any more work into this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
HTTPConnectionPoolwill be kept alive until the idle connection timeout has fired. I don’t see a reason to keep theHTTPConnectionPoolaround if the idle connection timeout future is the only thing that’s still referencing theHTTPConnectionPool.