Skip to content

Conversation

martin4861
Copy link
Contributor

@martin4861 martin4861 commented Oct 15, 2025

After the migration to bzl_mod the toolchain_path_prefix needs to be adapt. Using select is not possible here, but as all of our repos is using bzl_mod we can simplify the path selection anyways.
Moreover toolchain_path_prefix is only used for Mac builds.

@martin4861 martin4861 marked this pull request as ready for review October 15, 2025 08:55
@martin4861 martin4861 requested a review from a team as a code owner October 15, 2025 08:55
Copy link
Contributor

@armallen armallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look consistent, I was able to run and debug orion-engine/orion targets correctly 👍

@martin4861 martin4861 merged commit f89855a into main Oct 16, 2025
2 checks passed
@martin4861 martin4861 deleted the martin4861/bazelmod-toolchain-prefix branch October 16, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants