Skip to content

More Bazel 8 compatibility #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 6, 2025
Merged

Conversation

martin4861
Copy link
Contributor

@martin4861 martin4861 commented Aug 5, 2025

Follow up on #169

In order to use Bazel 8 following changes are needed:

  • select proper sysroots for some additional toolchains
  • + instead of ~ as bzl_mod path seperator (backwards compatibility to Bazel 7 can be achieved using --incompatible_use_plus_in_repo_names) for some more toolchains

Tested in

  • starling-core (Bazel 6)
  • starling-core (Bazel 7)
  • starling-core (Bazel 8)

@martin4861 martin4861 changed the title More Bazel 8 compatibility [WIP] More Bazel 8 compatibility Aug 5, 2025
@martin4861 martin4861 marked this pull request as ready for review August 5, 2025 15:14
@martin4861 martin4861 requested a review from a team as a code owner August 5, 2025 15:14
Copy link

@armallen armallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks consistent, are you still testing Bazel 6?

@martin4861
Copy link
Contributor Author

martin4861 commented Aug 6, 2025

Looks consistent, are you still testing Bazel 6?

I also tested the Bazel 6 compatibility in starling (see mentioned PR). ✅

@martin4861 martin4861 merged commit d796beb into main Aug 6, 2025
1 check passed
@martin4861 martin4861 deleted the martin4861/bazel-8-compatibility branch August 6, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants