Update standard to c++17 [OI-3403] #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peddie
approved these changes
Oct 13, 2025
@peddie llvm20 issues a deprecation warning when building with c++17, and we have "warning as errors" config. I see albatross uses c++14 standard, should I update CMake/Bazel build to c++17? |
armallen
changed the title
threadpool c++20 compatibility update threadpool c++17/c++20 compatibility update
armallen
commented
Oct 14, 2025
| branches: | ||
| - 'master' | ||
|
|
||
| concurrency: |
There was a problem hiding this comment.
Adding a commit to a PR will stop running workflows
armallen
commented
Oct 14, 2025
| }; | ||
|
|
||
| const auto proposed_params = apply(values, get_params); | ||
| const auto proposed_params = albatross::apply(values, get_params); |
There was a problem hiding this comment.
This was trying to use std::apply, which has different arguments
armallen
changed the title
threadpool c++17/c++20 compatibility update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
threadpoolhas c++17/c++20 compatibility issues because result_of is removed with c++20, and was deprecated in c++17.invoke_resultis used instead.Standard is updated to c++17 in albatross, which involves fixing
albatross::applycalls.