-
Notifications
You must be signed in to change notification settings - Fork 6
Add guide to run tutorials using a Jupyter Docker image #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for expanding on the documentation! I think we could simplify a couple of the steps with a Dockerfile
and maybe even using Docker compose. What do others think about that? Too much overhead? I'd be happy to do the dirty work, either in this PR or in a follow up.
tutorials/README.md
Outdated
3. **Launch the Docker container** | ||
|
||
```sh | ||
docker run -ti -p 8888:8888 -v `pwd`:/home/jovyan jupyter/datascience-notebook:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include the --rm
flag? https://docs.docker.com/reference/cli/docker/container/run/#rm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in a new commit of this PR. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just two small comments
tutorials/README.md
Outdated
**Command breakdown:** | ||
- `-ti`: Run in interactive mode with a TTY | ||
- `-p 8888:8888`: Map port 8888 from container to host | ||
- `-v \`pwd\`/albatross:/home/jovyan`: Mount the albatross directory into the container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the /albatross
part here I think should be removed?
Also a question, is the jovyan
the name of the users home directory in the Docker datascience-notebook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks!
tutorials/README.md
Outdated
- **Port 8888 already in use**: If you get a port binding error, either stop the existing service using port 8888 or use a different port: | ||
|
||
```sh | ||
docker run -ti -p 8889:8888 -v `pwd`/albatross:/home/jovyan jupyter/datascience-notebook:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Also remove /albatross
from here
Hopefully clarifies questions posted by @jbangelo and @IsakTjernberg (thanks!)
No description provided.