Skip to content

Upgrade cereal dependency[OC-2654] #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

john-michaelburke
Copy link
Contributor

@john-michaelburke john-michaelburke commented Jun 4, 2025

Upgrades the cereal dependency to https://github.com/USCiLab/cereal/releases/tag/v1.3.0

Tested when pulling this in all the way up the submodule chain in our codebase and no issues occur in CI.

@john-michaelburke john-michaelburke marked this pull request as ready for review June 18, 2025 23:41
Copy link
Contributor

@peddie peddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see these ancient deps getting a fresh look.

@jbangelo
Copy link
Contributor

How confident are we in their adherence to SemVer? Are we concerned if the serialization format isn't backwards compatible?

@john-michaelburke
Copy link
Contributor Author

How confident are we in their adherence to SemVer? Are we concerned if the serialization format isn't backwards compatible?

Like I said, this pass through CI all the way to the top, bit of a convoluted PR but it includes this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants