chore(deps): update actions/setup-node action to v6 #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add imports section to deno.json with all dependencies - Update all source files to use bare specifiers instead of inline imports - Regenerate deno.lock with correct hashes for new dependency resolution - Fixes lint errors: no-import-prefix and no-unversioned-import Co-Authored-By: swfz <[email protected]>
- Pin @std/ulid from @1 to @1.0.0 for more predictable dependency resolution - Regenerate deno.lock with pinned version Co-Authored-By: swfz <[email protected]>
- Load deno.json and pass import map to bundle() function - This allows the bundler to resolve bare specifiers like 'tiny-segmenter' - Fixes 'deno task build' which was failing after migrating to import maps Co-Authored-By: swfz <[email protected]>
- Remove trailing whitespace from lines 5 and 8 - Fixes deno fmt --check CI failure Co-Authored-By: swfz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Deno dependency management for new lint rules
Summary
This PR fixes CI failures caused by Deno's new lint rules (
no-import-prefixandno-unversioned-import) that require dependencies to be declared indeno.jsoninstead of using inline imports.Changes:
importssection todeno.jsonwith all 6 dependencies mapped to bare specifierslogger.ts,bundle.ts,params_test.ts,server.ts,render.ts) to use bare specifiersdeno.lock(v4 → v5 format) with correct hashes for new dependency resolution@std/ulidto exact version1.0.0for predictable dependency resolutionCI Status: ✅ All checks passing (fmt, lint, test)
Review & Testing Checklist for Human
deno task buildfailure is acceptable - The build task now fails because the emit bundler doesn't understand import maps. This task is NOT part of CI, but if you use it locally for development, we'll need to fix it separately (likely by configuring emit to use the import map or switching bundlers).deno task devand verify the server starts correctly and generates images as expected. CI only tests fmt/lint/test, not runtime behavior.deno.jsonare correct and match the actual imports in the code.Notes
jsr:,https://) have been replaced with bare specifiers as required by the new lint rulesdeno fmt --check✅,deno lint✅,deno test✅Devin Session: https://app.devin.ai/sessions/5bb3ce0fa7ea448da5f05fce40bf9d8a
Requested by: swfz ([email protected]) / @swfz