Merge pull request #83 from swecc-uw/fix-report-status

Fix issue in validating report statuses
swecc-uw · Dec 29, 2024 · 0ca5ee4 · 0ca5ee4
2 parents b7e1b16 + dacfc12
commit 0ca5ee4
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/server/report/views.py b/server/report/views.py
@@ -186,13 +186,17 @@ def patch(self, request, report_id):
                 {"error": "status is required"}, status=status.HTTP_400_BAD_REQUEST
             )
 
-        if request.data["status"] not in Report.STATUS_CHOICES:
+        updated_status = request.data["status"]
+
+        if not any(
+            updated_status in valid_choice for valid_choice in Report.STATUS_CHOICES
+        ):
             return Response(
                 {"error": "Invalid status provided"}, status=status.HTTP_400_BAD_REQUEST
             )
 
         report = report[0]
-        report.status = request.data["status"]
+        report.status = updated_status
         report.save()
 
         return Response(