Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: courses api from config #4998

Closed
wants to merge 1 commit into from
Closed

WIP: courses api from config #4998

wants to merge 1 commit into from

Conversation

shendel
Copy link
Collaborator

@shendel shendel commented Jan 22, 2022

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the work on the Testnet
  • I checked the work on the Mainnet
  • I checked the work in the plugin
  • I checked the PR once again

Tests

Please start auto tests as follows:

  • add a label swap test to start swap tests
  • add a label withdraw test to start withdraw tests

You can skip these tests if you completely sure that your changes aren't related to this functional

Original issue

#4994

Video / screenshot proof

Мержить после swaponline/multi-currency-wallet-pro#94

@shendel shendel added the draft Most likely, there will be changes in the issue. Not urgent or necessary for now. It needs planning label Jan 22, 2022
@shendel shendel closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
draft Most likely, there will be changes in the issue. Not urgent or necessary for now. It needs planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shendel