feat(oauth2-redirect): externalize inline script for CSP compliance #10559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(oauth2-redirect): externalize inline script for CSP compliance
Description
Moves the inline JavaScript code from oauth2-redirect.html into a new external file oauth2-redirect.js. The HTML now loads the script via a <script src="…"> tag instead of embedding it directly avoiding CSP problems...
Motivation and Context
Some environments enforce strict Content Security Policies (CSP) that block inline scripts (most of them by security purposes). This change ensures that the OAuth2 redirect page works in such environments by complying with CSP restrictions.
Impact???
Note: From what I understand, the /dist folder "part of it only" is updated by the maintainers during the release process, and the contents of dev-helpers/* are copied there at that time. I’ve therefore only updated the source files under dev-helpers and not touched /dist. I believe this is the correct approach, but please correct me if I’ve misunderstood the release workflow :/.
How Has This Been Tested?
locally using webpack dev server "npm run dev"
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests