Fix #7866: Incorrect handling of --model-name-prefix/suffix (typescri… #7869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x (typescript-angular)
macjohnny
reviewed
Mar 19, 2018
| @@ -377,7 +379,22 @@ public String toModelFilename(String name) { | |||
|
|
|||
| @Override | |||
| public String toModelImport(String name) { | |||
| return modelPackage() + "/" + toModelFilename(name); | |||
| // with modelNamePrefix/modelNameSuffix, name already includes | |||
There was a problem hiding this comment.
The implementation lookgs good and well-documented.
However, is there a reason why this isnt implemented in the ‚toModelFilename()‘ method?
There was a problem hiding this comment.
Yes, if you implement it in toModelFilename, the file name will become Error.ts, but the import will stay the same:
import { SwgError} from '../model/swgError';
I did run a test to confirm.
|
awesome, this PR will fix my issues |
gummibjorn
reviewed
Aug 30, 2018
| filename = StringUtils.removeEnd(filename, modelNameSuffix); | ||
| } | ||
|
|
||
| return modelPackage() + "/" + filename; |
There was a problem hiding this comment.
Filename is capitalised. import { SwgError} from '../model/SwgError'; leads to issues on case sensitive OS at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny
Description of the PR
Fix import in *.service.ts when using --model-name-prefix or --model-name-suffix
java -jar swagger-codegen-cli.jar generate -l typescript-angular --model-name-prefix swg
Before:
import { SwgSwgError } from '../model/swgSwgError';
After:
import { SwgError} from '../model/swgError';