Split out a RequestOptions function. #7295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brendandburns thanks for the PR. From what I can tell, it's not a breaking change. If no concern from @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx, I'll merge it into 2.4.0 this weekend. |
|
I can't seem to find the change in this PR which removes the ObjectSerializer from api.ts (the diff which is hidden by default because it's too big). @wing328 Do you know to which PR these changes are related or if the changes aren't an issue? |
|
Looks like @brendandburns is not using the latest master when creating the PR as all the localVar variable prefix has been removed. Please rebase on the latest master and update the TS node samples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
Split each API method in half to add a public facing
_operation_RequestOptions()method. The purpose of this method is to queue everything up ready to execute, but not actually execute it.This allows the user to intercept the request, make modifications, and execute it on their own. This is useful (for example) when you want to use a WebSockets protocol that nonetheless re-uses all of the auth and everything else from a RESTful API, or when a RESTful API has some methods that return raw streams of data instead of JSON.
Typescript technical committee:
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx