Skip to content

chore: clean up a11y analysis code #16345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 14, 2025
Merged

chore: clean up a11y analysis code #16345

merged 10 commits into from
Jul 14, 2025

Conversation

Ocean-OS
Copy link
Contributor

When reviewing #16340, #16341, and #16339 I realized how unorganized the code in packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y.js was, so I split it into two files and cleaned up a few things.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 11, 2025

🦋 Changeset detected

Latest commit: 21ed6c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16345

@dummdidumm
Copy link
Member

"Few things" are from what I can see mainly if->switch? Anything else?
I think we should name it a11y/index.js not a11y/utils.js, otherwise looks good.

@Ocean-OS
Copy link
Contributor Author

iirc that's all, I'll rename it in a bit

@Ocean-OS Ocean-OS merged commit 82f6481 into main Jul 14, 2025
14 checks passed
@Ocean-OS Ocean-OS deleted the cleanup-a11y branch July 14, 2025 19:06
@github-actions github-actions bot mentioned this pull request Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants