-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: clean up a11y analysis code #16345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 21ed6c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
"Few things" are from what I can see mainly if->switch? Anything else? |
iirc that's all, I'll rename it in a bit |
When reviewing #16340, #16341, and #16339 I realized how unorganized the code in
packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y.js
was, so I split it into two files and cleaned up a few things.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint