fix: only use iterator destructuring logic if there's an array pattern #16000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15996
The logic introduced in #15813 produce much more chunky code...while this is not really a problem since the generated code should gzip wonderfully we really don't need to use that logic unless there's an
ArrayPattern
in the declarator.I've added a snapshot test but I'm not sure is worth having but i can remove it easily if we think it's not worth.
Also this is walking the
ObjectPattern
because if at any point in the destructure there's an array we need to fall back to what @Ocean-OS introduced for the same reason.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint