Skip to content

vscode xxxData to xxxProps #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2025
Merged

vscode xxxData to xxxProps #2796

merged 5 commits into from
Jul 17, 2025

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Jul 15, 2025 •
edited
Loading

fixes: #2782

jycouet
jycouet commented Jul 15, 2025
View reviewed changes
Copy link
Contributor Author

@jycouet jycouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial PR. I'm not really sure what to test... Should I do a few templates ? How "real" ? With mocks ? or creating real projects ?

Or with the flag test it's already a first good step ?

Feel free to comment :)

dummdidumm
dummdidumm approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work, thank you so much!

@dummdidumm dummdidumm merged commit 2a0c8a0 into sveltejs:master Jul 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SvelteKit Files - Moving from xxxData to xxxProps
2 participants
@jycouet @dummdidumm