Fix disable auto closing tab when typing arrow of func #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2020 12:53
Auto closing tab of '>' is triggered by below.
- `<Button>` <- this is ok.
- `<Button on:click={() =>` <- this shouldn't be triggered.
I add codes to avoid second one.
|
Thanks for your contribution! We already had a PR for this which fixed the issue, so I cannot reproduce this anymore with the latest Svelte Beta. Could you tell me how to reproduce this? |
|
[reproduce version] https://marketplace.visualstudio.com/items?itemName=JamesBirtles.svelte-vscode Oh, I thought this plugin moved to this repository, but maybe wrong? It looks only the plugin Svelte Beta is maintained. |
|
This is the old version, Svelte Beta is the new, official and maintained one this repo is about. |
|
Oh I am totally sorry, didn't check about that. Thank you, and I close this. |
ghost
closed this
|
No problem! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto closing tab of
>is triggered by below.<Button><- this is ok.<Button on:click={() =><- this shouldn't be triggered.I add codes to avoid second one.