-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update tsconfig docs #4826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tsconfig docs #4826
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, though I think this probably belong in the 'Others are required for SvelteKit to work properly' section rather than the 'generated programmatically based on your project configuration' section?
I went back and forth on that quite a bit, if you think it does then I am all for it - SvelteKit works fine without it but the packaging will break unless you specifically change things |
Updated |
Co-authored-by: Ben McCann <[email protected]>
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0Forgot to change this in #4791