Skip to content

Bump marked to fix dependency version security warning #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Conversation

benmccann
Copy link
Member

Unrelated - while testing this, I was noticing some server-side rendering issues running the realworld app:

(node:11879) UnhandledPromiseRejectionWarning: TypeError: res.setHeader is not a function
    at eval (src/routes/auth/register.js:14:7)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:11879) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:11879) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
TypeError: Cannot read property 'body' of undefined
    at packages/kit/dist/renderer.js:2328:16
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

@Rich-Harris
Copy link
Member

Yeah, we need to finish #290 at some point

@Rich-Harris Rich-Harris merged commit ed6dcce into master Mar 2, 2021
@Rich-Harris Rich-Harris deleted the marked branch March 2, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants