Skip to content

fix: handle non-semver-style dependency versions #13850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2025
Merged

fix: handle non-semver-style dependency versions #13850

merged 3 commits into from
Jun 4, 2025

Conversation

dummdidumm
Copy link
Member

Fixes #13836

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 13ff753

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dummdidumm
dummdidumm commented Jun 2, 2025
View reviewed changes
dummdidumm
dummdidumm commented Jun 2, 2025
View reviewed changes
@benmccann benmccann added the pkg:svelte-package Issues related to svelte-package label Jun 3, 2025
benmccann
benmccann reviewed Jun 3, 2025
View reviewed changes
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense in the latest or next case, but a bit less in the workspace case described in #13553. Maybe we can check the value? If it's a workspace value it would be nice to resolve it or at least log that we're just making an assumption about what value to use whereas in the latest or next case you probably want to just silently proceed as is being done here

@jycouet
Copy link
Contributor

jycouet commented Jun 3, 2025

héhé, my PR is very close to this one! ^^ (with a warn already)

catalog* stuff is a nice feature, but it's quite new and package manager specific today. Maybe the fallback & warning is good enough for now?

@dummdidumm
Copy link
Member Author

I don't think we need a warning - this is about checking for Svelte 3, which is rarely used these days. People using catalogs are certainly using a newer version of Svelte, too.

@dummdidumm dummdidumm merged commit 1a40675 into main Jun 4, 2025
18 checks passed
@dummdidumm dummdidumm deleted the fix-semver branch June 4, 2025 09:25
@github-actions github-actions bot mentioned this pull request Jun 4, 2025
Merged
@jycouet
Copy link
Contributor

jycouet commented Jun 4, 2025

Almost made it to the repo :p
I'll close my PR 👍

Thank you

@jycouet jycouet mentioned this pull request Jun 4, 2025
Closed
6 tasks
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jun 14, 2025
@sidharthv96
Merge branch 'main' into sidv/styleText
d10dda9 
* main: (533 commits)
  Version Packages (sveltejs#13885)
  fix: sequential focus navigation starting point regression and hash routing (sveltejs#13884)
  feat: Respect abort signals during serverside fetch optimization (sveltejs#13877)
  fix: correct link to locals (sveltejs#13870)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13876)
  chore: update Vitest to 3.2.3 (sveltejs#13865)
  Version Packages (sveltejs#13872)
  fix: correctly access `app.decoders` in inline and single output apps (sveltejs#13871)
  chore(deps): update dependency @netlify/functions to v4 (sveltejs#13838)
  Version Packages (sveltejs#13854)
  chore(deps): update pnpm to v10.12.1 (sveltejs#13849)
  fix: avoid setting sequential focus navigation starting point when using hash router (sveltejs#13861)
  fix: hash link to new page focuses the correct element (sveltejs#10856)
  fix: ensure `redirect` used in packages uses the same `Redirect` instance (sveltejs#13843)
  fix: include components dynamically imported in the universal load function when inlining CSS (sveltejs#13723)
  fix: correctly invalidate static analysis cache of child nodes during dev (sveltejs#13793)
  fix: suppress console spam for chrome devtools requests (sveltejs#13830)
  fix: correctly deserialize on the server (sveltejs#13686)
  fix: handle non-semver-style dependency versions (sveltejs#13850)
  Attempt to clarify use:enhance docs (sveltejs#13819)
  ...
@schmittl schmittl mentioned this pull request Jun 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees
No one assigned
Labels
pkg:svelte-package Issues related to svelte-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@sveltejs/package fails with "Invalid comparator" when using Bun workspace catalogs
4 participants
@dummdidumm @jycouet @benmccann @elliott-with-the-longest-name-on-github