Skip to content

@sveltejs/package: Assume no svelte 3 if can't read version with semver (pnpm calalog) #13553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

@sveltejs/package: Assume no svelte 3 if can't read version with semver (pnpm calalog) #13553

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f529b2d
Assume no svelte 3 if can't read version with semver (pnpm calalog)
jycouet Mar 6, 2025
866d7ca
better linting ;)
jycouet Mar 6, 2025
aa5e28c
Update with suggestion
jycouet Mar 17, 2025
f68f27a
fix typo & format
jycouet Mar 17, 2025
2f2ff0c
info to warn
jycouet Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/package/src/typescript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@ export async function emit_dts(input, output, final_output, cwd, alias, files, t
const require = createRequire(import.meta.url);
const pkg = load_pkg_json(cwd);
const svelte_dep = pkg.peerDependencies?.svelte || pkg.dependencies?.svelte || '3.0';
const no_svelte_3 = !semver.intersects(svelte_dep, '^3.0.0');
let no_svelte_3 = true;
try {
no_svelte_3 = !semver.intersects(svelte_dep, '^3.0.0');
} catch (e) {
if (!(e instanceof Error)) throw e;
console.warn(`Can't check svelte version ${svelte_dep}`, e.message);
}
await emitDts({
libRoot: input,
svelteShimsPath: no_svelte_3
Expand Down
Loading