-
-
Notifications
You must be signed in to change notification settings - Fork 56
feat: add windows support #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add windows support #1355
Conversation
🦋 Changeset detectedLatest commit: 892547d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your Local
Published Instant Preview Packages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! Can you add changeset like this?
(I tried to push directly to your branch, but I didn’t have permission to do so.)
fix: properly support Windows in `no-unused-props` rule
fix: properly support Windows in `valid-style-parse` rule
fix: properly support Windows in `nno-unnecessary-condition` rule
Hello ! Hope you have a good day. Should I push the changesets directly without updating or make the tools cross platform ? |
I have plenty of time, no worries. I'll work on it when I'm back from work ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
This PR adds support for Windows environments.
It:
\n
as the end-of-line charactercloses #1335