Skip to content

Conversation

InkedCat
Copy link
Contributor

This PR adds support for Windows environments.

It:

  • Forces \n as the end-of-line character
  • Normalizes paths whenever possible to stay cross-platform
  • Enables Windows runners in NodeCI

closes #1335

Copy link

changeset-bot bot commented Sep 11, 2025

🦋 Changeset detected

Latest commit: 892547d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 12, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@892547d

Published Instant Preview Packages:

View Commit

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Can you add changeset like this?
(I tried to push directly to your branch, but I didn’t have permission to do so.)

fix: properly support Windows in `no-unused-props` rule
fix: properly support Windows in `valid-style-parse` rule
fix: properly support Windows in `nno-unnecessary-condition` rule

@InkedCat
Copy link
Contributor Author

InkedCat commented Sep 13, 2025

Thank you so much! Can you add changeset like this? (I tried to push directly to your branch, but I didn’t have permission to do so.)

fix: properly support Windows in `no-unused-props` rule
fix: properly support Windows in `valid-style-parse` rule
fix: properly support Windows in `nno-unnecessary-condition` rule

Hello ! Hope you have a good day.
I've tried to run pnpm update before adding the changesets, but it seems there are still some bugs related to Windows style paths in the package tools scripts. I'll need to change the writeAndFormat function signature to accept URL's, a URL will handle the conversion for every platform correctly.

Should I push the changesets directly without updating or make the tools cross platform ?

@baseballyama
Copy link
Member

Should I push the changesets directly without updating or make the tools cross platform ?

I’d be very happy if you could take care of it, but if you don’t have the time, I’d appreciate it if you could at least change the PR settings so that I can push.

image

@InkedCat
Copy link
Contributor Author

I have plenty of time, no worries. I'll work on it when I'm back from work !

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@baseballyama baseballyama merged commit d8df1e8 into sveltejs:main Sep 20, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte/no-unused-props misinterprets props as internal properties
2 participants