feat: support comma-separated ignore comments #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is two things: - performance improvements to the algorithm we use for extracting ignore comments - support for comma-separated ignore comments We can now support (as per svelte docs): ```html <!-- svelte-ignore code1, code2 --> ``` It also drops multi-line matching in the pattern to avoid matching this kind of funk: ```html <!-- some random multi-line content svelte-ignore code1 more content --> ```
🦋 Changeset detectedLatest commit: b6bd978 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
ota-meshi
requested changes
May 20, 2025
...ests/fixtures/rules/no-unused-svelte-ignore/valid/svelte-ignore-comma-separated-input.svelte
Show resolved
Hide resolved
43081j
force-pushed
the
ignore-comments-perf
branch
from
963d28c to
7f0023c
Compare
43081j
force-pushed
the
ignore-comments-perf
branch
from
7f0023c to
b6bd978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is two things:
We can now support (as per svelte docs):
<!-- svelte-ignore code1, code2 -->It also drops multi-line matching in the pattern to avoid matching this kind of funk: