Skip to content

fix(no-top-level-browser-globals): false positives for type annotations #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2025

Conversation

ota-meshi
Copy link
Member

fix #1226

Copy link

changeset-bot bot commented May 17, 2025

🦋 Changeset detected

Latest commit: b0410b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 17, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@b0410b0

Published Instant Preview Packages:

View Commit

@ota-meshi ota-meshi requested a review from baseballyama May 17, 2025 12:55
@baseballyama baseballyama merged commit c938185 into main May 17, 2025
17 checks passed
@baseballyama baseballyama deleted the fix-no-top-level-browser-globals branch May 17, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-top-level-browser-globals rule is flagging types as top level browser globals
2 participants