Skip to content

Tailwind style to lucia login #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

brettearle
Copy link

Tailwind styles added to make the login legible with tailwind selected

Copy link

changeset-bot bot commented Apr 19, 2025

⚠️ No Changeset found

Latest commit: b5dd1f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brettearle
Copy link
Author

@manuel3108 have added tailwind to this standard

Screenshot from 2025-04-19 10-59-41

@benmccann
Copy link
Member

This seems rather unexpected to me if you setup Lucia and not Tailwind

@brettearle
Copy link
Author

brettearle commented Apr 19, 2025 via email

@brettearle brettearle marked this pull request as draft April 19, 2025 03:24
@brettearle
Copy link
Author

or just make the styling inline normal css?

@brettearle
Copy link
Author

@benmccann would this be the way to do it? I was trying to use what already existed without adding new parameters etc.

@manuel3108 does this meet what you were expecting?

@brettearle brettearle marked this pull request as ready for review April 19, 2025 05:19
Copy link

pkg-pr-new bot commented Apr 19, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@540
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@540

commit: 56bd3d0

@manuel3108
Copy link
Member

Generally I think the proposed changes seem to be reasonable, to make the lucia page not destroyed in the minimal template by tailwind.

This code makes the assumption that the lucia integration is run after the tailwind integration, even if they are selected in the same prompt. If I have our add-on ordering code in mind correctly, this should currently always apply. But I will need to check this at a later stage.

Currently, this PR seems to introduce build errors while running the templates.

@brettearle
Copy link
Author

Awesome, I'll fix the build errors. Seems to just be the quotes causing issues. Will sort. Let me know if I can be a hand on the ordering system is needed.

@brettearle brettearle marked this pull request as draft April 19, 2025 22:38
@brettearle
Copy link
Author

In draft whilst I get pipeline working locally

@brettearle brettearle marked this pull request as ready for review April 20, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants