Skip to content

feat: Add MFA support for the WebAuthn recipe [v0.16.0] #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025

Conversation

bcbogdan
Copy link
Contributor

Summary of change

Include the shuoldTryLinkingWithSessionUser in the webauthn API requests.

Test Plan

Documentation changes

  • Update the SDK references

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • webJsInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

@bcbogdan bcbogdan force-pushed the feat/webauthn-mfa branch from 95bed5f to d98a18e Compare July 29, 2025 09:43
Copy link
Contributor

github-actions bot commented Jul 29, 2025

size-limit report 📦

Path Size
lib/build/index.js 27.5 KB (0%)
recipe/emailverification/index.js 27.84 KB (0%)
recipe/emailpassword/index.js 27.88 KB (0%)
recipe/thirdparty/index.js 28.58 KB (0%)
recipe/session/index.js 24.47 KB (0%)
recipe/passwordless/index.js 28.94 KB (0%)
recipe/userroles/index.js 24.74 KB (0%)
recipe/multitenancy/index.js 27.24 KB (0%)
recipe/multifactorauth/index.js 27.3 KB (0%)
recipe/totp/index.js 27.03 KB (0%)
recipe/oauth2provider/index.js 26.89 KB (0%)
recipe/webauthn/index.js 31.67 KB (+0.24% 🔺)

Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the changelog as well.

@coolbueb coolbueb changed the base branch from master to 0.16 July 31, 2025 13:30
@coolbueb coolbueb changed the title feat: Add mfa support for the webauthn recipe feat: Add MFA support for the WebAuthn recipe [v0.16.0] Aug 3, 2025
@bcbogdan bcbogdan force-pushed the feat/webauthn-mfa branch 2 times, most recently from 586af6d to 5f1ab80 Compare August 6, 2025 06:14
@bcbogdan bcbogdan requested a review from porcellus August 6, 2025 06:15
@porcellus porcellus merged commit f5276ac into 0.16 Aug 7, 2025
6 of 7 checks passed
@porcellus porcellus deleted the feat/webauthn-mfa branch August 7, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants