feat: adds test to check session cookie setting and timezone #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2025
porcellus
requested changes
Jun 11, 2025
| @@ -273,6 +273,28 @@ export const SessionMock: Partial<typeof Session> = { | |||
| }); | |||
| return deserializeSession(response); | |||
| }, | |||
| createNewSession: async ( | |||
There was a problem hiding this comment.
I don't think we need this.
There was a problem hiding this comment.
When I use the createNewSessionWithoutRequestResponse method that's already present, I don't see any set-cookie headers - possibly since there is no req/res object to add headers to
The session object has the expiry as a number, but we're concerned about the timezone that's sent in the header
refreshToken: {
createdTime: 1749703674308,
expiry: 1758343674308,
token: '...'
},
vs
Expires=Fri, 12 Jun 2026 05:10:37 GMT
| const signUp = async (tenantId, email, password, session, userContext) => { | ||
| const { response } = await queryAPI({ | ||
| method: "post", | ||
| path: "/test/emailpassword/signup", |
There was a problem hiding this comment.
why isn't this calling the normal signup api? ( "/auth/signup")
There was a problem hiding this comment.
I believe both are equivalent for this test. Both will internally call the recipe signup.
I can change it to the /auth/signup API
| }; | ||
| }; | ||
|
|
||
| const createNewSession = async ( |
There was a problem hiding this comment.
I don't think we need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.