Skip to content

fix: handle invalid JSON response in facets query #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyphercodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle invalid JSON response in facets query #813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion apps/web/components/memories-grid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,21 @@ export function MemoriesGrid({
throw new Error(response.error?.message || "Failed to fetch facets")
}

return response.data as FacetsResponse
// Validate response data to prevent JSON parse errors
const data = response.data as unknown
if (
data &&
typeof data === "object" &&
"facets" in data &&
Array.isArray(data.facets) &&
"total" in data &&
typeof data.total === "number"
) {
return data as FacetsResponse
}

// Return default values if response is invalid
return { facets: [], total: 0 }
},
staleTime: 5 * 60 * 1000,
enabled: !!user,
Expand Down