[SuperEditor] Fix immutability violation in spellchecking styler (Resolves #2560) #2568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor] Fix immutability violation in spellchecking styler (Resolves #2560)
A crash was reported within
spelling_and_grammar.dart
within_applyErrors()
where we try to do the following:I didn't find any places where we return an unmodifiable list from the the
grammarErrors
, but I think it's safer to replace the list instead of modifying it, because apps can add custom view models, that might return an unmodifiable list forgrammarErrors
.This PR changes the
SpellingAndGrammarStyler
to override the viewmodel'sspellingErrors
andgrammarErrors
.