Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RibShark FW detection #204

Closed
wants to merge 9 commits into from
Closed

RibShark FW detection #204

wants to merge 9 commits into from

Conversation

Deterous
Copy link
Contributor

@Deterous Deterous commented Jan 23, 2025

Logs whenever a RibShark-fw-looking drive reads 10 sectors into the leadout. The assumption is that 3.10MK FW drives will not read that far into the leadout (minimising false positives), and that RibShark FW drives should almost always be able to read at least 10 leadout sectors (minimising false negatives).

I have tested this with the 3.10MK FW (which returns true for the drive_is_asus_ribshark function) and it did not log for a PC CD, PSX CD, and an Audio CD. I then flashed RibShark FW, and it logged it for all 3 discs.

@Deterous Deterous closed this Jan 23, 2025
@Deterous Deterous reopened this Jan 23, 2025
@superg
Copy link
Owner

superg commented Jan 23, 2025

Why do we need this change?
It just logs the message post-factum - not useful.
Seeing this message is an equivalent of not seeing "LG/ASUS: searching lead-out in cache ...".
Just don't see the value and the check is pretty hardcoded.

@Deterous
Copy link
Contributor Author

RibShark firmware is on 3.10 firmware that redumper does not support lead-out cache reading.
I also found that the MakeMKV 3.10MK firmware could read at least one leadout sector on one disc I tested, without cache trick. Hence the 10 sectors check, rather than just 1.

The purpose is just to make it clearer that RibShark FW was used for redump submissions. We want to know if someone has dumped a CD with RIbshark firmware (as opposed to an LG/ASUS drive with scrambled support). Because RibShark's firmware looks identical (vendor string WM01601... ) to the MakeMKV firmware, this check should rule out that firmware.

@Deterous Deterous closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants