Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NHUB-532] Upgrade Wire to async resource #1143

Merged
merged 35 commits into from
Oct 31, 2024

Conversation

MarkLark86
Copy link
Contributor

Purpose

Upgrade Wire resource and search to async.

What has changed

Resolves: #NHUB-532
Note: Uses Superdesk branch NHUB-540 for now, will change once the Superdesk PR is merged.
Depends on superdesk/superdesk-core#2740

@MarkLark86 MarkLark86 added this to the v3.0 milestone Oct 28, 2024
@MarkLark86 MarkLark86 requested a review from eos87 October 28, 2024 05:57
dev-requirements.txt Outdated Show resolved Hide resolved
@MarkLark86 MarkLark86 requested a review from eos87 October 30, 2024 08:31
Copy link
Contributor

@eos87 eos87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the search service, it looks much better now!

I left a few minor comments/questions. Two last suggestions (don't have to be in this PR of course):

  • we should add some docstrings into the some of the most important methods
  • please update the dev-requirements as there are still some references to your local environment

newsroom/push/publishing.py Show resolved Hide resolved
newsroom/push/utils.py Outdated Show resolved Hide resolved
newsroom/search/filters.py Show resolved Hide resolved
newsroom/search/filters.py Show resolved Hide resolved
newsroom/wire/filters.py Outdated Show resolved Hide resolved
newsroom/wire/service.py Show resolved Hide resolved
@MarkLark86
Copy link
Contributor Author

Great job with the search service, it looks much better now!

I left a few minor comments/questions. Two last suggestions (don't have to be in this PR of course):

  • we should add some docstrings into the some of the most important methods
  • please update the dev-requirements as there are still some references to your local environment

Will add docstrings to the search class methods.
As for the dev-requirements, see pip-tools issue #2131. I've fixed this by find/replace. We won't have this issue once pip-tools fixes it.

@MarkLark86 MarkLark86 merged commit 86b328f into superdesk:async Oct 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants