-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NHUB-532] Upgrade Wire to async resource #1143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the search service, it looks much better now!
I left a few minor comments/questions. Two last suggestions (don't have to be in this PR of course):
- we should add some docstrings into the some of the most important methods
- please update the dev-requirements as there are still some references to your local environment
Will add docstrings to the search class methods. |
Purpose
Upgrade Wire resource and search to async.
What has changed
Resolves: #NHUB-532
Note: Uses Superdesk branch NHUB-540 for now, will change once the Superdesk PR is merged.
Depends on superdesk/superdesk-core#2740