Skip to content

refactor: Remove unnecessary parentheses in Bucket.fromJson #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

felixkamau
Copy link
Contributor

@felixkamau felixkamau commented Jul 10, 2025

What kind of change does this PR introduce?

Code cleanup / refactor

What is the current behavior?

There are unnecessary parentheses around json in some fromJson constructors like Bucket.fromJson, which slightly clutters the code.

What is the new behavior?

Removed redundant parentheses to make the code cleaner and more idiomatic Dart.

Additional context

This is a small code cleanup contribution to help improve readability.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16204056340

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.623%

Totals Coverage Status
Change from base Build 15886198956: 0.0%
Covered Lines: 3104
Relevant Lines: 3850

💛 - Coveralls

@felixkamau felixkamau changed the title refactor: remove unnecessary parentheses in Bucket.fromJson Refactor: remove unnecessary parentheses in Bucket.fromJson Jul 15, 2025
@Vinzent03 Vinzent03 changed the title Refactor: remove unnecessary parentheses in Bucket.fromJson refactor: Remove unnecessary parentheses in Bucket.fromJson Jul 15, 2025
@Vinzent03 Vinzent03 merged commit d729fa4 into supabase:main Jul 15, 2025
14 of 17 checks passed
@felixkamau felixkamau deleted the cleanup/remove-parens-fromJson branch July 15, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants