chore(deps): bump undici from 7.28.0 to 8.10.0 - #1308
Conversation
|
Found 126 test failures on Blacksmith runners: Failures
|
There was a problem hiding this comment.
LGTM — mechanical major-version bump of undici (7.28.0 → 8.10.0) with matching lockfile update.
Extended reasoning...
Overview
This PR only touches package.json and package-lock.json, bumping the direct dependency undici from ^7.24.0 to ^8.10.0. The lockfile changes are the mechanical byproduct of npm's dependency resolution (nested undici copies pulled in transitively by @platformatic/* packages and undici-thread-interceptor remain pinned to 7.x, which is expected and harmless since npm can have multiple major versions coexist in the tree).
Security risks
None introduced by this change itself — if anything, the bump pulls in several undici security fixes from the 8.x line (Cache-Control parsing, cookie attribute injection, stale Content-Length handling) per the release notes in the PR description. No application code changes accompany this bump.
Level of scrutiny
This warrants light scrutiny. It's a single dependency version bump with no source code modifications. I checked the codebase's direct usages of undici (Agent, Dispatcher, interceptors, request) in src/storage/renderer/image.ts, src/storage/events/lifecycle/webhook.ts, src/storage/cdn/cdn-cache-manager.ts, and src/internal/monitoring/pprof/client-http.ts — these all use long-stable, documented undici APIs that are unaffected by the 7→8 major bump's changelog (which is mostly HTTP/2, mock, and cache-interceptor focused). undici 8's Node engine requirement (>=22.19.0) is already satisfied by this repo's own engines.node: >=24.0.0 constraint, so no environment conflict.
Other factors
The bug hunting system found no issues. There is no existing PR discussion or prior review to reconcile. CI/test suite (unit + integration) would catch any behavioral regression from the bump, and the change is easily revertible if something surfaces post-merge.
Bumps [undici](https://github.com/nodejs/undici) from 7.28.0 to 8.10.0. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v7.28.0...v8.10.0) --- updated-dependencies: - dependency-name: undici dependency-version: 8.10.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7cefdd3 to
8897695
Compare
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.png)
Bumps undici from 7.28.0 to 8.10.0.
Release notes
Sourced from undici's releases.
... (truncated)
Commits
c8d80e6Bumped v8.10.0 (#5644)66923b4fix: preserve DNS origin hostname on sockets (#5577)3926499fix: retry refused HTTP/2 streams (#5598)73d6e9efix(h2): detach upgrade close handler after GOAWAY (#5641)b111adbfix(mock): emit request body lifecycle hooks (#5367)ae4a3e3build(deps): bump actions/setup-node from 6.4.0 to 7.0.0 (#5636)ec3fbf1build(deps): bump github/codeql-action/init from 4.36.2 to 4.37.3 (#5634)2151720build(deps): bump ossf/scorecard-action from 2.4.3 to 2.4.4 (#5633)b96a116fix(interceptors): allow interceptors without opts.origin (#5628)a18ef2dfix(mock): non-string path matchers under ignoreTrailingSlash, and DataView r...