Skip to content

fix: HS256 JWK signature verification #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2025
Merged

Conversation

edgurgel
Copy link
Member

What kind of change does this PR introduce?

Joken.Signer.create does not expect a map for HS256

What is the current behavior?

Failing with

(Joken.Error) Couldn't recognize the signer algorithm. Possible values are: ["HS256", "HS384", "HS512", "RS256", "RS384", "RS512", "ES256", "ES384", "ES512", "PS256", "PS384", "PS512", "Ed25519", "Ed25519ph", "Ed448", "Ed448ph"]

What is the new behavior?

Not failing

Additional context

Add any other context or screenshots.

Copy link

vercel bot commented Jul 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2025 9:53pm

@coveralls
Copy link

coveralls commented Jul 18, 2025

Coverage Status

coverage: 85.462% (+0.5%) from 84.994%
when pulling 5e8001b on fix/hs256-signature-verification
into 07c06aa on main.

@edgurgel edgurgel force-pushed the fix/hs256-signature-verification branch 2 times, most recently from b271211 to 237750d Compare July 18, 2025 03:36
@edgurgel edgurgel force-pushed the fix/hs256-signature-verification branch from 237750d to 645847c Compare July 20, 2025 21:30
@edgurgel edgurgel merged commit 0ce993d into main Jul 20, 2025
7 checks passed
@edgurgel edgurgel deleted the fix/hs256-signature-verification branch July 20, 2025 22:07
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.41.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants