-
-
Notifications
You must be signed in to change notification settings - Fork 201
feat: tighten gotrue.service deps and startup behavior #1783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrose
approved these changes
Sep 9, 2025
hunleyd
approved these changes
Sep 9, 2025
hf
approved these changes
Sep 9, 2025
b5b0819
to
f11bb0d
Compare
Add stronger ordering and dependency constraints to reduce startup race conditions and noisy flapping: - Wait for `cloud-init`, `supabase-admin-agent_salt`, `apparmor`, `systemd-sysctl`, and `ufw` to complete before starting. - Require `network-online.target` and `systemd-resolved` for stable DNS resolution; note Go's resolver can race with early boot DNS. - Ensure `postgresql.service` is online before starting auth to avoid misleading error noise during slow boots. - Lower `StartLimitIntervalSec` and `StartLimitBurst` to reduce repeated restarts in failure scenarios. - Switch service type to `exec` instead of `simple`. This removes the tiny window in which systemd is supervising the wrapper process instead of the Go binary. These changes aim to rule out capability changes, socket reuse races, and incomplete firewall/network config as causes of EADDRINUSE errors and unstable startup.
f2b61db
to
4fef515
Compare
…into cs/systemd-update
cstockton
added a commit
that referenced
this pull request
Sep 17, 2025
This reverts commit 493bd39.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stronger ordering and dependency constraints to reduce startup race conditions and noisy flapping:
cloud-init
,supabase-admin-agent_salt
,apparmor
,systemd-sysctl
, and ufw` to complete before starting.network-online.target
andsystemd-resolved
for stable DNS resolution; note Go's resolver can race with early boot DNS.postgresql.service
is online before starting auth to avoid misleading error noise during slow boots.StartLimitIntervalSec
andStartLimitBurst
to reduce repeated restarts in failure scenarios.exec
instead ofsimple
. This removes the tiny window in which systemd is supervising the wrapper process instead of the Go binary.These changes aim to rule out capability changes, socket reuse races, and incomplete firewall/network config as causes of EADDRINUSE errors and unstable startup.