Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): add functions setof type introspection #915

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

avallete
Copy link
Member

@avallete avallete commented Mar 30, 2025

What kind of change does this PR introduce?

This PR will set things up for: supabase/postgrest-js#614 to work.
Locally I've generated the types for supabase/postgrest-js#614 by using this PR local image build.

Already ported the changes for the functions fetching types toward the new repo: supabase/supabase#34548

@avallete avallete changed the title Feat/add functions setof type introspection feat(typescript): add functions setof type introspection Mar 30, 2025
Base automatically changed from fix/functions-typescript-type-definition to master March 31, 2025 17:25
@coveralls
Copy link

coveralls commented Mar 31, 2025

Pull Request Test Coverage Report for Build 14230635242

Details

  • 33 of 33 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 76.182%

Totals Coverage Status
Change from base Build 14195985967: 0.3%
Covered Lines: 5017
Relevant Lines: 6507

💛 - Coveralls

@@ -441,6 +445,11 @@ test('typegen: typescript', async () => {
id: number
"user-id": number
}[]
SetofOptions: {
from: "users" | "todos"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note

Like for the args, an embeded function can be linked to different tables. By receiving different rows as parameter.

@avallete avallete marked this pull request as ready for review April 1, 2025 10:05
@avallete avallete requested review from a team as code owners April 1, 2025 10:05
@avallete avallete requested a review from soedirgo April 1, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants