fix(pg-protocol): uncatchable error pg protocol #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
avallete
commented
Mar 27, 2025
avallete
commented
- Fixes: pg-protocol can throw an uncatchable error "Cannot create a string longer than 0x1fffffe8 characters" when reading large data brianc/node-postgres#2653
avallete
commented
Mar 27, 2025
| return this.parseCopyData(offset, length, bytes) | ||
| default: | ||
| return new DatabaseError('received invalid response: ' + code.toString(16), length, 'error') | ||
| try { |
There was a problem hiding this comment.
note
Actual code change, adding the try/catch block to handle any underlying parsing errors and bubble them up to the caller instead of uncatchable exception.
soedirgo
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.