feat(logs): Improve logs with spans #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
force-pushed
the
riccardobusetti/feat/add-more-data-to-logs
branch
from
f831319 to
241b81e
Compare
iambriccardo
changed the title
iambriccardo
commented
Jul 16, 2025
api/Cargo.toml
Outdated
| @@ -45,7 +45,7 @@ sqlx = { workspace = true, features = [ | |||
| thiserror = { workspace = true } | |||
| tokio = { workspace = true, features = ["rt-multi-thread", "macros"] } | |||
| tracing = { workspace = true, default-features = false } | |||
| tracing-actix-web = { workspace = true, features = ["emit_event_on_error"] } | |||
There was a problem hiding this comment.
We emit errors on our own.
imor
approved these changes
Jul 17, 2025
| let apply_worker_span = tracing::info_span!( | ||
| "apply_worker", | ||
| pipeline_id = self.pipeline_id, | ||
| publication_name = self.config.publication_name |
There was a problem hiding this comment.
Are pipeline_id and publication_name useful for every log line within the span? There's going to only one of each while the replicator is running. As opposed to something like a table_id which will be different.
There was a problem hiding this comment.
My idea was that we want a reliable way to get a view of all logs of a certain pipeline for debugging a single customer.
| @@ -145,7 +145,7 @@ async fn init_state_store( | |||
| Ok(PostgresStateStore::new(pipeline_id, pg_connection_config)) | |||
| } | |||
|
|
|||
| #[instrument(skip(pipeline))] | |||
| #[tracing::instrument(skip(pipeline), fields(pipeline_id = pipeline.id()))] | |||
There was a problem hiding this comment.
Same here, is pipeline_id needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves logging in several ways: