feat(cli): port functions new#5680
Open
7ttp wants to merge 3 commits into
Open
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Address code review on the functions new port: - Gate IDE settings scaffolding on text mode so json/stream-json runs stay payload-only and never write .vscode/.idea as an undisclosed side effect. - Append the [functions.<slug>] section with O_APPEND semantics (flag: "a") instead of read-then-rewrite, matching Go's appendConfigFile and removing the truncation risk on a partial write. - Move IDE write-error mapping into new.errors.ts as a path-parameterized helper, fixing the hardcoded .vscode path on IntelliJ failures. - Match Go's non-TTY prompt bytes (trailing space) and document the raw-text vs parsed-config declaration scan divergence. - Add a config.toml write-failure test and flip the json-mode test to assert no IDE files are written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Ports
supabase functions newto the native tsWhats Introduced?
This replaces the proxy-backed
functions newpath with a native legacy TypeScript implementationthat preserves the command’s local scaffolding flow, including auth specific templates,
supabase/config.tomlupdates, first function IDE setup promptsw integration coverage around the main paths and edge cases...
Ref