Fix issue where if the headers contain From it overrides the Custom SMTP From #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
requested changes
Mar 23, 2025
There was a problem hiding this comment.
thanks for contributing @davidshq!
hmm the headers passed into the Mail function do not contain the recipient's address though - just wondering, where are you seeing this?
| @@ -81,17 +81,19 @@ func (m *MailmeMailer) Mail( | |||
| return err | |||
| } | |||
|
|
|||
| mail := gomail.NewMessage() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Under some circumstances headers may be passed that override the From field. This can cause emails to come from application users instead of from the Custom SMTP Sender details and will often result in email delivery failures since most SMTPs only accept emails from approved senders.
What is the current behavior?
#1957
What is the new behavior?
Updates via headers to From are ignored, the correct Custom SMTP Sender details are preserved.